Skip to content

Conversation

pierwill
Copy link
Contributor

@pierwill pierwill commented Jan 26, 2022

Part of work on #90317. Ord for PlaceRef ultimately depends on DefId being Ord.

The data structure previously used here required Ord.
As part of rust-lang#90317, we do not want DefId to implement Ord.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 26, 2022
@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2022
@rust-log-analyzer

This comment has been minimized.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2022
@pierwill pierwill force-pushed the another-defid-branch branch from 35c3d68 to a9a3f0b Compare January 26, 2022 03:40
@pierwill pierwill force-pushed the another-defid-branch branch from a9a3f0b to 7630680 Compare January 26, 2022 03:42
@pierwill pierwill closed this Jan 28, 2022
Aaron1011 added a commit to Aaron1011/rust that referenced this pull request May 10, 2022
This fixes rust-lang#96449, but I haven't yet been able to
make the reproducer work using `#[cfg]` attributes,
so we can't use the 'revision' infra to write a test

The previous implementation relied on sorting by `PlaceRef`.
This requires sorting by a `DefId`, which uses untracked state
(see rust-lang#93315)
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2022
…ochenkov

Use `FxIndexSet` to avoid sorting fake borrows

This fixes rust-lang#96449, but I haven't yet been able to
make the reproducer work using `#[cfg]` attributes,
so we can't use the 'revision' infra to write a test

The previous implementation relied on sorting by `PlaceRef`.
This requires sorting by a `DefId`, which uses untracked state
(see rust-lang#93315)
Aaron1011 added a commit to Aaron1011/rust that referenced this pull request May 11, 2022
This is a new attempt at rust-lang#93315. It removes one usage
of the `Ord` impl for `DefId`, which should make it easier
to eventually remove that impl.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2022
…r-errors

Remove `PartialOrd`/`Ord` impl for `PlaceRef`

This is a new attempt at rust-lang#93315. It removes one usage
of the `Ord` impl for `DefId`, which should make it easier
to eventually remove that impl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants